test(multichain): fusdc "advance and settle" as a macro #10692

0xpatrickdev · 2024-12-13T17:02:20Z

refs: #10597

Description

tests additional FUSDC happy paths with agoric and noble EUDs
"oracles accept" test conditionally accepts invitations

Security Considerations

None, only tests

Scaling Considerations

None, ~60s hit to CI (each advance + settle is about 30s)

Documentation Considerations

None

Testing Considerations

PR is only tests

Upgrade Considerations

None

turadg · 2024-12-13T17:08:01Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

@@ -34,7 +34,7 @@ const accounts = [...keys(oracleMnemonics), 'lp'];
 const contractName = 'fastUsdc';
 const contractBuilder =
  '../packages/builders/scripts/fast-usdc/init-fast-usdc.js';
-const LP_DEPOSIT_AMOUNT = 10_000_000n;
+const LP_DEPOSIT_AMOUNT = 8_000n * 10n ** 6n;


we have the 10^6 as a constant somewhere but this is clear enough. better than the literal

turadg · 2024-12-13T17:10:17Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

-    'published.agoricNames.instance',
-  );
-  const instance = fromEntries(instances)[contractName];
+  // TODO export/import INVITATION_MAKERS_DESC


should not be imported. the test should be declaring what it expects the value to be, not just that it matches something else.

consider if someone changed the value in the other module. the test should fail and have to be updated to make clear that the API changed.

turadg · 2024-12-13T17:11:46Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

-  );
-  const instance = fromEntries(instances)[contractName];
+  // TODO export/import INVITATION_MAKERS_DESC
+  const ORACLE_INV_DESC = 'oracle operator invitation';


for the reason above I think this shouldn't have ALL_CAPS casing. defining the value at all is just a convenience in this function to not have to repeat it.

```suggestion const description = 'oracle operator invitation';

cloudflare-workers-and-pages · 2024-12-13T17:30:48Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`4ce1540`
Status:	✅ Deploy successful!
Preview URL:	https://1c8772b1.agoric-sdk.pages.dev
Branch Preview URL:	https://pc-fusdc-multichain-macro.agoric-sdk.pages.dev

View logs

dckc

I'd like to talk over a suggestion to factor out roles / participants with makeOracleOperator(...) and such.

dckc · 2024-12-13T17:23:45Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+    const hasInvitation = invitations.some(
+      x => x.description === ORACLE_INV_DESC,
+    );
+    const usedInvitation = offerToUsedInvitation?.[0]?.[0] === `${name}-accept`;


Suggested change

const usedInvitation = offerToUsedInvitation?.[0]?.[0] === `${name}-accept`;

const usedInvitation = offerToUsedInvitation.some(([id, _v]) => id === `${name}-accept`);

dckc · 2024-12-13T17:32:19Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+
+  // ensure we have an unused (or used) oracle invitation in each purse
+  let hasAccepted = false;
+  for (const name of keys(oracleMnemonics)) {


There's a lot going on in this loop.

If we reify the oracle operators as objects somewhat like makeOracleOperator or makeAgoricWatcher, we can make this read much more straightforwardly:

Suggested change

for (const name of keys(oracleMnemonics)) {

for (const op of oracleOperators) {

const status = await oracle.invitationCheck(); // returns the invitation or `used` if used;

t.log({ name: op.name, status });

t.truthy(status);

}

dckc · 2024-12-13T17:37:22Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+    t.true(hasInvitation || usedInvitation, 'has or accepted invitation');
+    if (usedInvitation) hasAccepted = true;
+  }
+  // if the oracles have already accepted, skip the rest of the test this is


Suggested change

// if the oracles have already accepted, skip the rest of the test this is

// if any of the oracles have already accepted, skip the rest of the test this is

right?

dckc · 2024-12-13T17:38:42Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

-  );
-  t.log('settlementAccount address', settlementAccount);
+const advanceAndSettleScenario = test.macro({
+  title: (_, mintAmt: bigint, eudChain: string) =>


eudChain is kinda... tortured

Suggested change

title: (_, mintAmt: bigint, eudChain: string) =>

title: (_, mintAmt: bigint, destChain: string) =>

dckc · 2024-12-13T17:43:36Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+    } = t.context;
+
+    // EUD wallet on the specified chain
+    const eudWallet = await createWallet(


likewise...

Suggested change

const eudWallet = await createWallet(

const destWallet = await createWallet(

I'd rather avoid using the ambient random source inside createWallet. I don't suppose we have a widget where you pass crypto.randomBytes(plenty) and it makes a mnemonic, do we? Or can we pass in a private key?

I can imagine this isn't worthwhile just now, so... adding it to the list:

Distressing proliferation of ambient authority #2160

dckc · 2024-12-13T18:09:28Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

-    aux: {
-      forwardingChannel: nobleAgoricChannelId,
+    // register forwarding address on noble
+    const txRes = nobleTools.registerForwardingAcct(


again, lots going on; my tiny brain wants the roles (user, noble chain, ...) reified as objects.

dckc · 2024-12-13T18:11:19Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+
+    // submit evidences
+    await Promise.all(
+      oracleWds.map(makeDoOffer).map((doOffer, i) =>


would love to see...

Suggested change

oracleWds.map(makeDoOffer).map((doOffer, i) =>

oracleOperators.map(op => op.submit(evidence));

github-actions · 2024-12-13T18:19:46Z

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

dckc · 2024-12-13T20:19:37Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+    const { offerToUsedInvitation, purses } = await vstorageClient.queryData(
+      `published.wallet.${wallets[name]}.current`,
+    );
+    const { value: invitations } = balancesFromPurses(purses)[Invitation];


Does that work?

balancesFromPurses returns a map, right? and Invitation is a Brand

samsiegart · 2024-12-13T22:46:13Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+    operators.map(async op => {
+      const { invitation, usedInvitation } = await op.checkInvitation();
+      t.log({ name: op.getName(), invitation, usedInvitation });
+      t.true(invitation || usedInvitation, 'has or accepted invitation');


Shouldn't this map function return usedInvitation for the logic below to work? If it doesn't return anything then checks.some(Boolean) would always be false right?

dckc · 2024-12-16T03:27:14Z

I haven't gotten set up to test this locally; using ci to test it is pretty slow.

Let's roll back to before @0xpatrickdev handed this to me and see if it's green. If so, I can do my refactor in a follow-on.

dckc · 2024-12-16T22:53:38Z

No quorum: flake in z:acceptance governance?

flake?

[z:acceptance] Running test.sh.

ACCEPTANCE TESTING governance
...

  ✘ [fail]: economic committee can make governance proposal and vote on it
...
        reason: 'No quorum',
...
Error: Command failed: docker run -e SLOGFILE -v "$SLOGFILE:/home/runner/test.slog" --rm ghcr.io/agoric/agoric-3-proposals:test-acceptance

Mon, 16 Dec 2024 04:10:39 GMT

- include `agoric` and `noble` EUD destinations

- mainly to facilitate active development; allows test to be run more than once

mergify · 2024-12-17T01:02:24Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ integration-test-result
☑️ linear-history

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

dckc · 2024-12-17T04:15:59Z

psm acceptance flake?

in a3p-integration/proposals/z:acceptance/psm.test.js

https://github.com/Agoric/agoric-sdk/actions/runs/12363738833/job/34505666038?pr=10692#step:10:8349

0xpatrickdev requested a review from a team as a code owner December 13, 2024 17:02

0xpatrickdev requested review from AgoricTriage, turadg, dckc and samsiegart December 13, 2024 17:02

turadg approved these changes Dec 13, 2024

View reviewed changes

0xpatrickdev force-pushed the pc/provision-sw-flake branch from 0daf237 to 0cdb981 Compare December 13, 2024 17:24

0xpatrickdev force-pushed the pc/fusdc-multichain-macro branch from 57494a3 to 4a1e603 Compare December 13, 2024 17:30

dckc reviewed Dec 13, 2024

View reviewed changes

Base automatically changed from pc/provision-sw-flake to master December 13, 2024 18:19

dckc reviewed Dec 13, 2024

View reviewed changes

samsiegart reviewed Dec 13, 2024

View reviewed changes

dckc force-pushed the pc/fusdc-multichain-macro branch 5 times, most recently from 3ee3fbe to 6134570 Compare December 14, 2024 00:18

dckc added the force:integration Force integration tests to run on PR label Dec 14, 2024

dckc force-pushed the pc/fusdc-multichain-macro branch 4 times, most recently from 44f280c to e084cac Compare December 15, 2024 04:40

dckc mentioned this pull request Dec 16, 2024

SPIKE: factor out Orch contract core-eval boilerplate #10695

Draft

2 tasks

dckc force-pushed the pc/fusdc-multichain-macro branch from e084cac to 4a1e603 Compare December 16, 2024 03:25

dckc mentioned this pull request Dec 16, 2024

z:acceptance governance fails/flakes: No quorum #10708

Closed

dckc added the automerge:rebase Automatically rebase updates, then merge label Dec 17, 2024

0xpatrickdev and others added 3 commits December 17, 2024 00:16

test: advance and settle as a macro

092056b

- include `agoric` and `noble` EUD destinations

chore: "oracles accept" handles already accepted invs

1eb9eb1

- mainly to facilitate active development; allows test to be run more than once

test(acceptance): skip make proposal and vote; seems flaky

4ce1540

0xpatrickdev force-pushed the pc/fusdc-multichain-macro branch from 295e818 to 4ce1540 Compare December 17, 2024 00:16

mergify bot merged commit 9e124c3 into master Dec 17, 2024
81 checks passed

mergify bot deleted the pc/fusdc-multichain-macro branch December 17, 2024 05:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(multichain): fusdc "advance and settle" as a macro #10692

test(multichain): fusdc "advance and settle" as a macro #10692

0xpatrickdev commented Dec 13, 2024

turadg Dec 13, 2024

turadg Dec 13, 2024

turadg Dec 13, 2024

cloudflare-workers-and-pages bot commented Dec 13, 2024 •

edited

Loading

dckc left a comment

dckc Dec 13, 2024

dckc Dec 13, 2024

dckc Dec 13, 2024

dckc Dec 13, 2024

dckc Dec 13, 2024

dckc Dec 13, 2024

dckc Dec 13, 2024

dckc Dec 13, 2024

github-actions bot commented Dec 13, 2024

dckc Dec 13, 2024

samsiegart Dec 13, 2024

dckc commented Dec 16, 2024

dckc commented Dec 16, 2024

mergify bot commented Dec 17, 2024

dckc commented Dec 17, 2024

	const usedInvitation = offerToUsedInvitation?.[0]?.[0] === `${name}-accept`;
	const usedInvitation = offerToUsedInvitation.some(([id, _v]) => id === `${name}-accept`);

-  for (const name of keys(oracleMnemonics)) {
+  for (const op of oracleOperators) {
+    const status = await oracle.invitationCheck(); // returns the invitation or `used` if used;
+    t.log({ name: op.name, status });
+    t.truthy(status);
+  }

	// if the oracles have already accepted, skip the rest of the test this is
	// if any of the oracles have already accepted, skip the rest of the test this is

	title: (_, mintAmt: bigint, eudChain: string) =>
	title: (_, mintAmt: bigint, destChain: string) =>

	const eudWallet = await createWallet(
	const destWallet = await createWallet(

	oracleWds.map(makeDoOffer).map((doOffer, i) =>
	oracleOperators.map(op => op.submit(evidence));

test(multichain): fusdc "advance and settle" as a macro #10692

test(multichain): fusdc "advance and settle" as a macro #10692

Conversation

0xpatrickdev commented Dec 13, 2024

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Dec 13, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc commented Dec 16, 2024

dckc commented Dec 16, 2024

No quorum: flake in z:acceptance governance?

mergify bot commented Dec 17, 2024

dckc commented Dec 17, 2024

psm acceptance flake?

cloudflare-workers-and-pages bot commented Dec 13, 2024 •

edited

Loading